Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pvi entries for hdf writing #31

Merged
merged 10 commits into from
Sep 4, 2023

Conversation

evalott100
Copy link
Contributor

@evalott100 evalott100 mentioned this pull request Sep 1, 2023
@evalott100 evalott100 linked an issue Sep 1, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07% 🎉

Comparison is base (defc6f6) 89.90% compared to head (4606954) 89.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #31      +/-   ##
==========================================
+ Coverage   89.90%   89.97%   +0.07%     
==========================================
  Files           7        7              
  Lines        1109     1117       +8     
  Branches      175      175              
==========================================
+ Hits          997     1005       +8     
  Misses         79       79              
  Partials       33       33              
Files Changed Coverage Δ
src/pandablocks_ioc/_pvi.py 92.70% <ø> (ø)
src/pandablocks_ioc/_hdf_ioc.py 94.81% <100.00%> (+0.32%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexanderWells-diamond AlexanderWells-diamond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

src/pandablocks_ioc/_pvi.py Outdated Show resolved Hide resolved
Copy link
Contributor

@AlexanderWells-diamond AlexanderWells-diamond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@evalott100 evalott100 merged commit ad1809a into PandABlocks:dev Sep 4, 2023
9 of 10 checks passed
@evalott100 evalott100 deleted the pvi_entries_for_hdf_writing branch September 5, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pvi entries for hdf writing
2 participants